Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicated time in result set bug #14782

Merged
merged 4 commits into from
Feb 6, 2025
Merged

Fix duplicated time in result set bug #14782

merged 4 commits into from
Feb 6, 2025

Conversation

JackieTien97
Copy link
Contributor

To replay you can use the following sqls (remember to disable cross_space_compaction)

create database db;
use db;
create table table1(id1 tag, s1 string);
insert into table1 values(0, 'd1', null), (1,'d1', 1);
flush;
insert into table1 values(0, 'd1', 0);
flush;
select * from table1;

previously, you will get duplicate timestamp 0

+-----------------------------+---+----+
|                         time|id1|  s1|
+-----------------------------+---+----+
|1970-01-01T08:00:00.000+08:00| d1|   0|
|1970-01-01T08:00:00.000+08:00| d1|null|
|1970-01-01T08:00:00.001+08:00| d1|   1|
+-----------------------------+---+----+

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 6, 2025

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov Codecov
Copy link

codecov bot commented Feb 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.51282% with 23 lines in your changes missing coverage. Please review.

Project coverage is 39.35%. Comparing base (024b05c) to head (4d740e1).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...engine/schemaregion/utils/ResourceByPathUtils.java 0.00% 17 Missing ⚠️
.../org/apache/iotdb/db/utils/ErrorHandlingUtils.java 0.00% 5 Missing ⚠️
...ageengine/dataregion/memtable/TsFileProcessor.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master   #14782      +/-   ##
============================================
- Coverage     39.49%   39.35%   -0.14%     
  Complexity      193      193              
============================================
  Files          4482     4489       +7     
  Lines        285122   286231    +1109     
  Branches      35326    35484     +158     
============================================
+ Hits         112596   112654      +58     
- Misses       172526   173577    +1051

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JackieTien97 JackieTien97 merged commit a966f82 into master Feb 6, 2025
45 of 47 checks passed
@JackieTien97 JackieTien97 deleted the AlignedQueryBug branch February 6, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jt2594838 jt2594838 jt2594838 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JackieTien97 @jt2594838